ggml-webgpu: Fix dequantization helpers to not pass in pointers#21872
Merged
reeselevine merged 3 commits intoggml-org:masterfrom Apr 15, 2026
Merged
ggml-webgpu: Fix dequantization helpers to not pass in pointers#21872reeselevine merged 3 commits intoggml-org:masterfrom
reeselevine merged 3 commits intoggml-org:masterfrom
Conversation
github-actions
Bot
added
ggml
reeselevine
changed the title
reeselevine
added
the
merge ready
ggerganov
removed
the
merge ready
reeselevine
added
the
merge ready
Contributor
Author
|
Fixed merge conflicts, also increased precision of |
Member
Ooops, snap (I'll close #21940). :) |
CISC
approved these changes
Apr 15, 2026
Contributor
Author
|
@ggml-org/maintainers can I get another review on this PR? |
pwilkin
approved these changes
Apr 15, 2026
mengqin
pushed a commit
to mengqin/llama.cpp
that referenced
this pull request
Apr 20, 2026
…-org#21872) * Fix dequantization helpers to not pass in pointers * Increase XIELU precision
ArberSephirotheca
pushed a commit
to ArberSephirotheca/llama.cpp
that referenced
this pull request
Apr 21, 2026
…-org#21872) * Fix dequantization helpers to not pass in pointers * Increase XIELU precision
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Apr 23, 2026
…-org#21872) * Fix dequantization helpers to not pass in pointers * Increase XIELU precision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Unfortunately, one of the changes in #21521 to pass buffers as pointers into helper loader functions ended up breaking the WebGPU backend on Firefox, as it does not yet seem to support the WGSL
unrestricted_pointer_parameterslanguage extension. So, this PR efactors the helpers back to specialized loader functions for different buffer names for now.Requirements